Enable LOAD DATA LOCAL INFILE for PHP >= 5.6.17 when mysqlnd is used. #12710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… See https://bugs.php.net/bug.php?id=68077 Added setting "load_data_infile_remote" to skip local file access for setups where database and webserver are not on the same system.
MichaelRoosz
force-pushed
the
fix_BatchInsert
branch
from
91156b8
to
d234c9a
Compare
|
Added setting "load_data_infile_remote" to skip local file access for setups where database and webserver are not on the same system. |
|
Thanks for the PR @MichaelHeerklotz 👍 We will review & merge it shortly. |
robocoder
reviewed
Apr 18, 2018
core/Db/BatchInsert.php
Outdated
|
|
||
| /* | ||
| * Second attempt: using the LOCAL keyword means the client reads the file and sends it to the server; | ||
| * the LOCAL keyword may trigger a known PHP PDO\MYSQL bug when MySQL not built with --enable-local-infile | ||
| * @see http://bugs.php.net/bug.php?id=54158 | ||
| */ | ||
| $openBaseDir = ini_get('open_basedir'); | ||
| $openBaseDir = !empty(ini_get('open_basedir')) && !(function_exists('mysqli_get_client_stats') && version_compare(PHP_VERSION, '5.6.17', '>=')); |
There was a problem hiding this comment.
$openBaseDir loses its meaning when conflating open_base_dir with mysqlnd detection.
InfinityVoid
pushed a commit
to InfinityVoid/matomo
that referenced
this pull request
Oct 11, 2018
…matomo-org#12710) * Enable LOAD DATA LOCAL INFILE for PHP >= 5.6.17 when mysqlnd is used. See https://bugs.php.net/bug.php?id=68077 Added setting "load_data_infile_remote" to skip local file access for setups where database and webserver are not on the same system. * Switch to using multi_server_environment config and tweak boolean logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug was fixed for mysqlnd in PHP 5.6.17, so "LOAD DATA LOCAL INFILE" can be used when mysqlnd is used and PHP => 5.6.17,
function_exists('mysqli_get_client_stats') is used to check whether mysqlnd is active.
See https://bugs.php.net/bug.php?id=68077