Removed '-' when editing password in users manager #12698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed '-' when editing password, so it does not need to be manually removed Fixed indentation issues.
InfinityVoid
pushed a commit
to InfinityVoid/matomo
that referenced
this pull request
Oct 11, 2018
Removed '-' when editing password, so it does not need to be manually removed Fixed indentation issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed - when editing password, so it does not need to be manually removed
Removed editable class from username, that way no special if-statement is needed in manage-users.controller.js
I also fixed minor indentation issues.
I found this little dash (-) being present when changing fairly annoying, and the first 3 times i did not catch it. So i was thinking it would improve UX a bit by removing it.
Due to the nature of how it's being built at this time ( being filled with input fields upon clicking them) i think this solution is pretty ok.