@diosmosis opened this Pull Request on April 5th 2018 Member

Avoids later errors if user clicks on a link w/ the invalid idSite.

Fixes #12617

@matomo-org/core-team I wonder if it would also be good not to swallow this exception: https://github.com/matomo-org/matomo/blob/3.x-dev/core/Plugin/Controller.php#L133
The error would have made a lot more sense to me w/ an "invalid idSite" message.

TODO:

  • [ ] check if this solves the cloud issue, perhaps by patching staging
@diosmosis commented on April 6th 2018 Member

Updated

@tsteur commented on April 7th 2018 Owner

I think it might make still sense to swallow this exception, or not really sense but might cause many other random bugs we cannot foresee so better to maybe just keep it now 👍

@diosmosis commented on April 10th 2018 Member

Updated.

This Pull Request was closed on April 10th 2018
Powered by GitHub Issue Mirror