When flattening url action reports the
default_action_name (default: index) is still contained in the labels.
This changes will remove that.
Also, I think there's probably test coverage for flattened actions reports, but if not, would be good to cover this change in a test.
The default action name will still be displayed for non flattened reports. Changing it also won't change any old reports...
I have seen that. I'm not yet sure how to solve that best without regressions... Need to investigate that further...
@mattab guess I now found a way how to always have a leading slash. But one thing needs to be clear here: Changing that might break some custom alerts defined by users. CustomAlerts plugin uses flatten reports for comparing actions. As the returned actions changes (leading slash and removed default action name) this might change results of defined alerts...
@sgiehl the tests results look good now :+1:
@sgiehl i was expecting that the PR includes the change in global.ini.php:
action_default_name = or
action_default_name = / , why not?
@mattab As the title says it currently only changes flattened reports.
action_default_name would change all reports. And it would only affect new data, all already tracked data and generated reports wouldn't change.
@sgiehl Makes sense. And what do you think about the idea of changing the setting to
/ or empty string, in a separate PR, to make it consistent with the flattened reports? Would there be any issue with this approach maybe?
We maybe should only do that for new installs as otherwise we might create inconsistency between old and new tracked data & reports.
Also setting it to
/ might be logically incorrect. We never store a leading slash for any action. So an empty string might be more correct...
@sgiehl noticed there's an integration test failing in CustomAlerts, could you update the submodule so the test passes?
Sure. Would do that directly before merging. Is everything else here good to merge?