Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve realtime visitor log widget #12659

Merged
merged 4 commits into from May 2, 2018
Merged

Improve realtime visitor log widget #12659

merged 4 commits into from May 2, 2018

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Mar 27, 2018 •
edited

Now realtime log reuses existing logic so icons and referrer information is displayed the same

Also hides the Keyword not defined tooltip in visitor log...

fixes #12655

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Mar 27, 2018
@sgiehl sgiehl added this to the 3.4.1 milestone Mar 27, 2018
@sgiehl sgiehl force-pushed the realtimevisitors branch 2 times, most recently from be26646 to 5c53e4b Compare April 1, 2018 16:42
@sgiehl sgiehl force-pushed the realtimevisitors branch 2 times, most recently from 6f76aa7 to 7e9a5af Compare April 25, 2018 09:02
@diosmosis
Copy link
Member

Noticed a couple issues:

  • On initial load the live visitor log has good alignment:

image

but immediately after the first load, it shifts to the right a bit:

image

Checked on chrome, no other browsers.

  • The IP address w/ visitor ID tooltip is no longer showing and the provider is no longer in the location tooltip (CC @mattab is this ok?).

Otherwise, looks good.

@mattab
Copy link
Member

mattab commented May 2, 2018

yes, reckon it's better without Visitor IP (which is accessible in the user profile, and often anonymised anyway)

@sgiehl could you please fix the alignment issue reported above in a separate PR?

@mattab mattab merged commit 795c729 into 3.x-dev May 2, 2018
@mattab mattab deleted the realtimevisitors branch May 2, 2018 08:34
@sgiehl sgiehl mentioned this pull request May 7, 2018
Merged
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
@sgiehl @InfinityVoid
Improve realtime visitor log widget (matomo-org#12659)
062e559 
* Show referrer information in realt time visitors widget same as in visitor log

* Reuse exisiting logic for realtime log

* do not show 'keyword not defined' tooltip in visitor log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.

In the Visitors in Real time widget, do not write "Keyword not defined"
3 participants
@sgiehl @diosmosis @mattab