Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show a special offer if one is defined for a plugin #12652

Merged
merged 1 commit into from Mar 27, 2018
Merged

Show a special offer if one is defined for a plugin #12652

merged 1 commit into from Mar 27, 2018

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Mar 27, 2018

Tried to integrate it into the description remotely from the marketplace but doesn't look as good as this solution:
image

@tsteur tsteur added the Needs Review PRs that need a code review label Mar 27, 2018
@tsteur tsteur added this to the 3.4.0 milestone Mar 27, 2018
sgiehl
sgiehl approved these changes Mar 27, 2018
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works

@tsteur tsteur merged commit 716ce33 into 3.x-dev Mar 27, 2018
@tsteur tsteur deleted the marketplacespecialoffer branch March 27, 2018 18:30
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
@tsteur @InfinityVoid
Show a special offer if one is defined for a plugin (matomo-org#12652)
e78acb1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsteur @sgiehl