Ensure number of rows and row metadata equals in processed reports #12650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
not-in-changelog
sgiehl
changed the title
diosmosis
requested changes
Mar 26, 2018
There was a problem hiding this comment.
Tested locally & it works, can a test be added, eg, to https://github.com/matomo-org/matomo/blob/3.x-dev/tests/PHPUnit/System/BlobReportLimitingTest.php ?
|
@diosmosis What kind of test would you expect? The existing System tests already show that there are now empty row metadata columns |
|
@sgiehl oh I see, missed those in the PR files. |
InfinityVoid
pushed a commit
to InfinityVoid/matomo
that referenced
this pull request
Oct 11, 2018
…atomo-org#12650) * Ensure number of rows and row metadata equals so they can be matched by ID * reset $rowsMetadata to empty DataTable if no row had metadata * update test files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Processed Reports currently contain an array of all rows and metadata contains an array of all row metadata. As rows without metadata didn't add an entry to the row metadata it can happen that the number of rows and row metadata doesn't match (e.g. for
Others-rows). That makes it impossible to iterate over both arrays and assume the row and metadata with the same array index belongs to each other.By always adding an empty row metadata, the number matches and #11825 should be fixed "automatically"
fixes #11825