Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fatal error: Cannot unset string offsets in JqplotDataGenerator #12627

Closed
tsteur opened this issue Mar 18, 2018 · 3 comments · Fixed by #12796
Closed

Fatal error: Cannot unset string offsets in JqplotDataGenerator #12627

tsteur opened this issue Mar 18, 2018 · 3 comments · Fixed by #12796
Assignees
@sgiehl
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
3.5.0

Comments

@tsteur
Copy link
Member

tsteur commented Mar 18, 2018

Following error happened on index.php?date=2018-03-18&viewDataTable=graphVerticalBar&module=VisitTime&action=getByDayOfWeek&widget=1&columns_to_display=nb_actions%2Cnb_uniq_visitors&idSite=1&period=week

"message":"Cannot unset string offsets","file":"plugins\/CoreVisualizations\/JqplotDataGenerator.php","line":106

Haven't tried to reproduce myself so not sure if it is an easy fix or not.
@tsteur tsteur added the Bug For errors / faults / flaws / inconsistencies etc. label Mar 18, 2018
@sgiehl
Copy link
Member

sgiehl commented Mar 18, 2018

Can be easily reproduces on demo: https://demo.matomo.org/index.php?date=2018-03-18&viewDataTable=graphVerticalBar&module=VisitTime&action=getByDayOfWeek&widget=1&columns_to_display=nb_actions,nb_uniq_visitors&idSite=7&period=week

But that might be by design. columns_to_display is handled as array, but a string is given in URL. Correct would be columns_to_display[]=nb_actions&columns_to_display[]=nb_uniq_visitors

Need to investigate if we generate such broken urls anywhere in the code...

@mattab mattab added this to the 3.4.1 milestone Mar 31, 2018
@mattab
Copy link
Member

mattab commented Mar 31, 2018

(It is also reproduced several times by customers)

@sgiehl
Copy link
Member

sgiehl commented Mar 31, 2018

Do you know a way to reproduce it in Matomo without calling the API directly (with incorrect params)

@sgiehl sgiehl self-assigned this Apr 30, 2018
@sgiehl sgiehl mentioned this issue Apr 30, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
3.5.0
Development

Successfully merging a pull request may close this issue.

Convert comma separated param values to arrays if needed matomo-org/matomo
3 participants
@tsteur @mattab @sgiehl