Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger DB failed exception also for POST API requests #12621

Merged
merged 1 commit into from Mar 15, 2018
Merged

Trigger DB failed exception also for POST API requests #12621

merged 1 commit into from Mar 15, 2018

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Mar 15, 2018

Currently, we show the error only when an API request is done via GET but I think it should be also shown when it is a POST. By passing null it will actually use GET + POST.

@tsteur tsteur added Bug For errors / faults / flaws / inconsistencies etc. Needs Review PRs that need a code review labels Mar 15, 2018
sgiehl
sgiehl approved these changes Mar 15, 2018
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsteur tsteur merged commit 012089b into 3.x-dev Mar 15, 2018
@tsteur tsteur deleted the dbfailedapi branch March 15, 2018 21:03
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
@tsteur @InfinityVoid
Trigger DB failed exception also for POST API requests (matomo-org#12621
abd20f0 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. Needs Review PRs that need a code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsteur @sgiehl