Ensure to also install plugins when there is a POST request #12619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
Bug
sgiehl
requested changes
Mar 15, 2018
core/FrontController.php
Outdated
| || empty($_GET['action']) | ||
| || $_GET['module'] !== 'Installation' | ||
| || !in_array($_GET['action'], array('getInstallationCss', 'getInstallationJs'))) { | ||
| $module = Common::getRequestVar('module', false, 'string'); |
There was a problem hiding this comment.
combination of default value false and variable type string doesn't make much sense, as it will always result in an empty string as returned default value (as it will be casted to string)
Also wondering if we maybe should use Piwik::getModule() and Piwik::getAction() here
There was a problem hiding this comment.
combination of default value false and variable type string doesn't make much sense, as it will always result in an empty string as returned default value (as it will be casted to string)
I know, it's still empty though and we use it in various places like this.
Using Piwik:getModule etc makes sense 👍
sgiehl
approved these changes
Mar 16, 2018
InfinityVoid
pushed a commit
to InfinityVoid/matomo
that referenced
this pull request
Oct 11, 2018
…rg#12619) * Ensure to also install plugins when there is a POST request * reuse existing methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this was implemented like this on purpose? But currently we wouldn't be installing any plugin until a request is posted. This can cause various problems for example when a new plugin is activated, but then the user only POSTS requests to API. This requests will then possibly fail as the plugin is not installed.