Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AutoSuggest tests for segments with date types #12610

Merged
merged 2 commits into from Mar 11, 2018
Merged

Fix AutoSuggest tests for segments with date types #12610

merged 2 commits into from Mar 11, 2018

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Mar 9, 2018

All AutoSuggest tests ran with a date time from NOW() - 30 days. This was required as auto suggest only suggests values for the last 60 days. The new date/time segments are failing again and again, as the results vary from day to day.

I've now implemented an option to modify the look back time for suggestions, so we can use a fixed date for tests

fixes #12606

@sgiehl sgiehl added c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Mar 9, 2018
@sgiehl sgiehl added this to the 3.3.1 milestone Mar 9, 2018
@tsteur
Copy link
Member

tsteur commented Mar 11, 2018

Looks good! Makes sense to always use same date 👍

@sgiehl sgiehl merged commit 0a95fd3 into 3.x-dev Mar 11, 2018
@sgiehl sgiehl deleted the fixtest branch March 11, 2018 19:25
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
* Fake Lookback range and date time for autosuggest tests to persist results

* update test files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build is currently failing for segments visitEndServerDate, visitEndServerMonth, visitEndServerDayOfWeek
2 participants