Add getCrossDomainLinkingUrlParameter() to allow users to add pk_vid to dynamic links. #12603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diosmosis
force-pushed
the
12602-pk_vid-param-get
branch
2 times, most recently
from
01bdfc2
to
4e70434
Compare
|
Looks good 👍 |
|
looks good! Feedback:
|
…query param to dynamic links themselves.
diosmosis
force-pushed
the
12602-pk_vid-param-get
branch
from
99177f5
to
11297c8
Compare
|
@mattab the next build should pass. |
InfinityVoid
pushed a commit
to InfinityVoid/matomo
that referenced
this pull request
Oct 11, 2018
…to dynamic links. (matomo-org#12603) * Add getCrossDomainLinkingUrlParameter() to allow users to add pk_vid query param to dynamic links themselves. * Update piwik JS files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
pk_vid=...string that can be directly appended to the query string on URLs.Fixes #12602