@diosmosis opened this Pull Request on March 7th 2018 Member


  • Add new getCrossDomainLinkingUrlParameter() method to JS tracker which returns the pk_vid=... string that can be directly appended to the query string on URLs.
  • Added the ability to mock the now value in JS tracker tests.

Fixes #12602

@tsteur commented on March 7th 2018 Member

Looks good 👍

@mattab commented on March 8th 2018 Member

looks good! Feedback:

  • Build is failing (integration test) with minified /piwik.js is out of date, please re-generate the minified files using instructions in /js/README
  • Some JS tests are failing for some reason: https://travis-ci.org/matomo-org/matomo/jobs/350138667
  • Could you also prepare the FAQ/Dev docs updates?
@diosmosis commented on March 8th 2018 Member

@mattab the next build should pass.

This Pull Request was closed on March 8th 2018
Powered by GitHub Issue Mirror