Added cookie_domain setting for third party cookie #12593
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, created a new rebased PR to fix the tests: #12632 |
|
Thanks for the PR @MichaelHeerklotz and @diosmosis for re-creating the PR! it has been merged and will be available in Matomo 3.4.0 next week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added setting "cookie_domain" for third party cookies.
This is useful, when piwik is running on a subdomain, and you want to access the global visitorid (_pk_uid) from your websites.
Maybe it would be also a good idea to adjust the JS API to allow easy access to the global visitorid.
At the moment this is just a proposal, I will contact @mattab .