Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add matomo/component-cache and use new version #12589

Closed
wants to merge 2 commits into from

Conversation

diosmosis
Copy link
Member

@diosmosis diosmosis commented Mar 5, 2018

NOTE: do not merge this until the component-cache PR is merged & a new release made, AND after this PR is updated w/ the new version. Currently it's using a branch so we can see the tests pass.

Changes:

  • Update matomo/cache version & uses of Piwik\Cache => Matomo\Cache throughout Piwik core.
  • Include original 1.X piwik/cache to keep backwards compatibility.

Note: the system test failure exists on 3.x-dev as well, not sure if it's random or not.

@@ -31,8 +31,8 @@

'path.cache' => DI\string('{path.tmp}/cache/tracker/'),

'Piwik\Cache\Eager' => function (ContainerInterface $c) {
$backend = $c->get('Piwik\Cache\Backend');
'Matomo\Cache\Eager' => function (ContainerInterface $c) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diosmosis is this change name change needed from Piwik\Cache\Eager' to Matomo\Cache\Eager? Doesn't it break API? In reality, it is still a Piwik\Cache\Eager or not?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see, yes that would be a BC break. I'll keep it and make it an alias to Matomo\Cache\Eager (we need both for autowiring).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, that might break since the types aren't the same, I'll have to think on this some.

@diosmosis diosmosis closed this Mar 5, 2018
@tsteur tsteur deleted the cache-backend-events branch April 15, 2020 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants