Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matomo, Tracking URLs, http vs https, visitor log issues #12586

Closed
ryrun opened this issue Feb 27, 2018 · 8 comments
Closed

Matomo, Tracking URLs, http vs https, visitor log issues #12586

ryrun opened this issue Feb 27, 2018 · 8 comments
Labels
duplicate For issues that already existed in our issue tracker and were reported previously.
Milestone

Comments

@ryrun
Copy link

ryrun commented Feb 27, 2018

We have changed serveral websites to https. All users will be redirected via 301, all urls on our site was changed to https, too. First problem is, that Matomo's visitor log still shows "http" urls, which cant be possible, because the users will be redirected.

It seems this problem is an old one, someone posted it on the forum, too:
https://forum.matomo.org/t/tracking-von-https-in-url-wird-nur-http-angezeigt/22990 (german post)

The second problem is, that we are currently not 100% sure, when we use the "URLs" configuration for websites, that "https" will be also consididerd like the "non-www"/"www", when we have just used "http://www.example.org". There are some missing informations about this. This need to be clarified more.

@mattab
Copy link
Member

mattab commented Sep 25, 2018

Hi @ryrun
Thanks for the feedback.

-> can you please set only the HTTPS URLs in your website (in Admin > websites > Manage > edit). Then are the URLs displayed in the visitor log shown for HTTPS links only?

I can't remember exactly the logic but if your website URLs are defined as HTTPS in Matomo, and your users are viewing https page, then for sure it's expected we show HTTPS links in the visitor log.
-> Could you please confirm if it's working for you in Matomo 3.6.0 or not?

The second problem is, that we are currently not 100% sure, when we use the "URLs" configuration for websites, that "https" will be also consididerd like the "non-www"/"www", when we have just used "http://www.example.org". There are some missing informations about this. This need to be clarified more.

Sounds good, we will clarify this in the UI.

Proposed steps to solve the issue

  • Confirm whether linking to HTTPS is partially not working as expected
  • Improve the inline help for definining website URLs and clarify that HTTPS and HTTP don't need to be specified like you don't need to specify with and without www.

@mattab mattab added this to the 3.8.0 milestone Sep 25, 2018
@mattab mattab modified the milestones: 3.9.0, 3.10.0 Mar 18, 2019
@tsteur
Copy link
Member

tsteur commented Apr 12, 2019

I can't reproduce it. Just debugged and the protocol is used under which is was tracked originally: https://github.com/matomo-org/matomo/blob/3.9.1/plugins/Actions/VisitorDetails.php#L141

It can happen though if an HTTP url was tracked in the past because of this: https://github.com/matomo-org/matomo/blob/3.9.1/core/Tracker/Model.php#L179

We store the action based on a hash of the url but the protocol is ignored in the hash. @mattab explained two months ago or so this was done to not create one action entry for each different protocol and to save storage and improve performance big times. If we were to change this, we would probably need to change a lot of reports too as we would likely need to group by more reports (which may lead in inaccurate results for unique metrics etc and lots of other problems).

We could try to match the domain/path with any URL configured in the site and use the same protocol as configured there instead I suppose. Not sure re possible side effects.

@mattab
Copy link
Member

mattab commented Apr 12, 2019

We could try to match the domain/path with any URL configured in the site and use the same protocol as configured there instead I suppose. Not sure re possible side effects.

Nice idea. But maybe this is not really important to fix actually and can be moved out of milestone?

@tsteur
Copy link
Member

tsteur commented Apr 12, 2019

I couldn't reproduce it, because the action was initially tracked under the right url_prefix.

But if you used to have http, and the url was first tracked under http, and then remove http from your website and only have https, then the link for that url will stay http basically.

@ryrun
Copy link
Author

ryrun commented Apr 12, 2019

Sorry @mattab i missed your post last year. I've set to https Urls only, but it still shows http://.
When no protocol will be indexed, what about using just "Protocol relative url's"? (https://en.wikipedia.org/wiki/URL#prurl)
Could be abit confusing for the users when they check the url, but as far as i can see Matomo already dont display url protocols.
Could be explained in the FAQ or Manual why Matomo does this.
And maybe you can add an option to index every url with protocol for new webpages.

@mattab mattab removed this from the 3.10.0 milestone Apr 23, 2019
@mattab mattab added this to the 3.12.0 milestone Jun 5, 2019
@tsteur tsteur modified the milestones: 3.13.0, 3.14.0 Nov 5, 2019
@mattab mattab modified the milestones: 3.14.0, 4.1.0 Nov 6, 2019
@mattab mattab modified the milestones: 4.1.0, 4.2.0 Dec 21, 2020
@sgiehl
Copy link
Member

sgiehl commented Jan 26, 2021

refs #5312

@tsteur
Copy link
Member

tsteur commented Jun 16, 2021

@sgiehl can we close this one maybe?

@sgiehl
Copy link
Member

sgiehl commented Jun 17, 2021

Yes. guess everything else can be handled in #5312

@sgiehl sgiehl closed this as completed Jun 17, 2021
@mattab mattab added the duplicate For issues that already existed in our issue tracker and were reported previously. label Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate For issues that already existed in our issue tracker and were reported previously.
Projects
None yet
Development

No branches or pull requests

4 participants