Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possible error in tag cloud visualization #12581

Merged
merged 1 commit into from Mar 6, 2018
Merged

Fix possible error in tag cloud visualization #12581

merged 1 commit into from Mar 6, 2018

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Feb 24, 2018

fixes #12578

Was not able to reproduce, but the view did not handle if columns_to_display[1] was not set. But as the visualization does, it now passes the result to the view...

@sgiehl sgiehl added Bug For errors / faults / flaws / inconsistencies etc. Needs Review PRs that need a code review labels Feb 24, 2018
@sgiehl sgiehl added this to the 3.3.1 milestone Feb 24, 2018
@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. and removed Bug For errors / faults / flaws / inconsistencies etc. labels Feb 24, 2018
@tsteur
Copy link
Member

tsteur commented Feb 24, 2018

Haven't tested it but looks good

@sgiehl sgiehl merged commit 91b7606 into 3.x-dev Mar 6, 2018
@sgiehl sgiehl deleted the tagcloud branch March 6, 2018 21:46
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cloud visualisation may display error "Key 1 for array with keys 0 does not exist"
2 participants