@simivar opened this Pull Request on February 21st 2018 Contributor

New system check diagnostic for max_execution_time (#11050)

I don't know if I didn't overdid it. If so and you don't like the new PhpSettingsCheckService class feel free to close that PR and I'll make new PR with different approach.

If PhpSettingsCheckService is fine should I move it to DI like Translator?

@sgiehl commented on June 18th 2018 Member

@simivar do you have some time to adjust this PR so the check for max_execution_time only produces a warning instead of an error?

@simivar commented on June 18th 2018 Contributor

@sgiehl Yes, I'll do that on Wednesday / Thursday.

Powered by GitHub Issue Mirror