@simivar opened this Pull Request on February 21st 2018 Contributor

New system check diagnostic for max_execution_time (#11050)

I don't know if I didn't overdid it. If so and you don't like the new PhpSettingsCheckService class feel free to close that PR and I'll make new PR with different approach.

If PhpSettingsCheckService is fine should I move it to DI like Translator?

@sgiehl commented on June 18th 2018 Member

@simivar do you have some time to adjust this PR so the check for max_execution_time only produces a warning instead of an error?

@simivar commented on June 18th 2018 Contributor

@sgiehl Yes, I'll do that on Wednesday / Thursday.

@diosmosis commented on July 24th 2018 Member

hi @simivar, will you have time to apply the requested changes this week?

@simivar commented on July 31st 2018 Contributor

hi @diosmosis, sorry for such late reply but I was away on vacation and just came back today. I'll apply them this week.

@simivar commented on August 6th 2018 Contributor

@mattab @diosmosis Updated, sorry that it took so long.
image

@diosmosis commented on August 6th 2018 Member

fyi @mattab merging this in 3.6.0 since it's done & working

@diosmosis commented on August 6th 2018 Member

@simivar thanks for the awesome contribution!

This Pull Request was closed on August 6th 2018
Powered by GitHub Issue Mirror