Add new Filesystem.allCachesCleared event after all caches cleared. #12568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
reviewed
Feb 19, 2018
|
|
||
| /** | ||
| * Triggered after all non-memory caches are cleared (eg, via the cache:clear | ||
| * command). |
There was a problem hiding this comment.
Actually the PiwikCache::flushAll(); above also clears the Lazy, Transient and Eager cache.
There was a problem hiding this comment.
Yes, but the event isn’t fired every time the in memory caches are cleared, that’s just a side effect of this method. The purpose of the filesystem method is to clear non-memory caches (and if you’re going to do that, it doesn’t make sense to keep the in memory ones.
I think adding that detail would eventually result in confusion.
sgiehl
approved these changes
Feb 19, 2018
tsteur
approved these changes
Feb 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.