New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GDPR + Add a couple of new platform features especially around validating settings #12558
Conversation
core/Settings/Setting.php
Outdated
@@ -158,6 +158,16 @@ public function configureField() | |||
|
|||
$this->setUiControlIfNeeded($this->config); | |||
$this->checkType($this->config); | |||
if (empty($this->config->availableValues) && in_array($this->type, array(FieldConfig::TYPE_FLOAT, FieldConfig::TYPE_INT, FieldConfig::TYPE_STRING))) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might have to remove this again, or implement the HTML5 validation features into our settings to highlight the errors etc. Will need to be tested with MaterializeCSS etc. If this worked it would be epic.
lang/en.json
Outdated
"ValidatorErrorNotANumber": "The value is not a number.", | ||
"ValidatorErrorNumberTooLow": "The value %s is too low. The value needs to be at least %s.", | ||
"ValidatorErrorNumberTooHigh": "The value %s is too high. The value should be at most %s", | ||
"ValidatorErrorCharacterTooShort": "The value contains %s characters but needs to contain at least %s characters.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to change the messages later.
@@ -140,6 +140,12 @@ | |||
} | |||
}); | |||
|
|||
$scope.$watch('inlineHelp', function (val, oldVal) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now makes sure to update inlineHelp when the variable changes.
@@ -122,15 +122,19 @@ var piwikHelper = { | |||
return; | |||
} | |||
|
|||
angular.element(document).injector().invoke(function($compile) { | |||
var scope = angular.element($element).scope(); | |||
angular.element(document).injector().invoke(function($compile, $rootScope) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Options.scope was not working properly and not used. Fixed it and improved the api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For clarification, does this mean the options.scope
object has to be an angular scope object now, rather than just a plain object? If yes, would be help to clarify that in the parameter docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that is what it means, I'll update the docs and clarify.
<li>Document your use of Matomo within your information asset register.</li> | ||
<li>Make sure that you are inserting our opt-out feature on all pages collecting personal data.</li> | ||
<li>Is your business currently registered to an Privacy Commissioner Office?</li> | ||
<li>Did you clearly informed your visitors on your privacy policy page about their different rights and that you are using Matomo?</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean by a "Privacy Commissioner Office"? I can't find many (European) sources for this.
Have you asked Ronan if he has an idea on how to write this description?
And I'd write "Have you clearly ..."
I'll add tests once the general concept for GDPR is reviewed. The content can then be adjusted afterwards. |
Bug: when exporting data subject's data on "All websites", with an "Admin" user that has only access to one of the websites, getting the error: |
In the test processed XML files, the keys are not translated and appear as the key itself eg. |
Fixed selector style and job status.
Will update UI tests later |
…ting settings (matomo-org#12558) * add a couple of new platform features especially around validating settings * more validators and other tweaks * few tweaks * allow plugins to add header script in JS tests * some work on gdpr * remove email feature * menu update * add date tooltip * make sure privacy has its own icon * added some text * add opt out info * better titles * add some information about webserver logs * add log import notice * give angular some time to render * show border around iframe * make sure to place a notification in modal dialog if needed * when opening a modal, make sure the top part is visible * disable newsletter sign up by default * command line tool to anonymize and remove previously tracked raw data * implement some basic consent features into piwik.js * minor tweak * schedule entries to anonymize data in past * let users anonymize historical data * better overview * better naming * explain consent tracking * add legitimate interest * new menu structure for privacy * use a proper db table for scheduled anonymizations * add some tracker tests * some tests and fixes * couple of fixes and tests * starting to add some UI tests * more tweaks * add missing file * fix jslint * have the field full width * more tweaks * create directory if needed * various fixes * fix some tests * make sure keys will be always returned in same order * more fixes * fix some tests * apply feedback from review * fix some tests * this might fix mysqli tests * fix some tests * trying to fix mysqli tests * fix system test * fix comment * remove some duplicated code * update method name * trigger event when logs need to be deleted * add possibility to anonymize userId and orderId * trigger event in tracking code page * expire consent in hours * post another event * update wording for privacy GDPR * fix various ui tests * fix some tests * trying to fix ui tests * trigger another test run * fix system test * fix some ui tests * show a table of contents on tracking code page, fix title, add mobile apps and API * fix ui test * 3.5.0-b2 update * Re-generate piwik.js * fix job status and selector style * make sure to include only sites with admin access * some tweaks * fix some ui tests * fix some ui tests * fix test
refs #12600 #12595 #12596 #12598 #12599 #12641