Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] GeoIP 2 integration #12553

Closed
wants to merge 54 commits into from
Closed

[WIP] GeoIP 2 integration #12553

wants to merge 54 commits into from

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Feb 12, 2018 •
edited

  • (visually) rename current GeoIP location providers to GeoIP Legacy
  • Deprecate GeoIP Legacy
    • Hide providers once a GeoIP 2 provider has been activated
  • Implement GeoIP2 location provider
    • PHP (w/ php extension)
    • Apache / Nginx ?
  • Implement new auto updater to update GeoIP2 databases
  • Change UI to download/update GeoIP2 databases instead of GeoIP Legacy
    • GeoIP Legacy updater should still work until switched to GeoIP2
    • Show information about configured GeoIP Legacy updater until switched to GeoIP2 (without possibility to change config)
  • Provide mapping from iso region codes to region names
    -> done using a console command to import region names from debian/iso-codes package
  • Update tests to work with GeoIP2, but maybe leave some GeoIP legacy tests
  • Implement migration script that needs to be run after update
    • old region code (FIPS) needs to be updated to new ones (ISO)
    • Should also update old region/country code for Tibet [ti|1 => cn|14] (refs Show Tibet as part of China on map #11930)
    • Should remove old custom country codes of GeoIP Legacy (such as AP, EU, A1, A2)
    • Make it somehow possible to run migration in browser (without possible timeouts)
    • How will old archives be updated?
  • Adjust VisitorGenerator plugin to fake new region codes not needed

fixes #4487
refs #12411

@sgiehl sgiehl added the Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. label Feb 12, 2018
@sgiehl sgiehl self-assigned this Feb 12, 2018
@sgiehl sgiehl force-pushed the geoip2 branch 7 times, most recently from 173a4a8 to 1258b21 Compare February 21, 2018 17:27
@sgiehl sgiehl force-pushed the geoip2 branch 19 times, most recently from b515a2e to 6a28b25 Compare March 5, 2018 07:47
@sgiehl sgiehl force-pushed the geoip2 branch 2 times, most recently from 4efb99f to ad888a2 Compare March 12, 2018 20:46
sgiehl added 25 commits April 1, 2018 18:45
@sgiehl
correct test locations
e93fa13
@sgiehl
Revert "adds second level subdivision translations"
0f62c82 
This reverts commit ec8c8b2.
@sgiehl
Revert "Adds console command to create region name translations out o…
4721027 
…f Maxminds GeoIP city data"

This reverts commit 9728d6f.
@sgiehl
Revert "Adds region name translation created with new console command"
2475c4f 
This reverts commit 7c1e182.
@sgiehl
Generate ISO region names based on dabian/iso-code and use them
c20923e
@sgiehl
update iso codes for china
ac12b18
@sgiehl
update test files
883eebc
@sgiehl
Add console command to convert log tables to new region codes
8684845
@sgiehl
add some more code mappings
994b419
@sgiehl
change format of new region name files to old format
76a03cf
@sgiehl
GeoIP Legacy: covert FIPS codes to ISO
296b0d7
@sgiehl
Add update script to disable GeoIP2 plugin from marketplace and store…
2f305d1 
… date of switch to iso region codes
@sgiehl
bump version number
a7269f9
@sgiehl
remove useless code
2bccf04
@sgiehl
also fix tibet region in update command
e07cd10
@sgiehl
add some more mappings
4ee99f0
@sgiehl
Improve GeoIP2 autoupdater
891ff00
@sgiehl
code improvements & cleanup
ca86cf4
@sgiehl
fix old invalid country codes in update command
b7c8946
@sgiehl
fix tests
1c0a77a
@sgiehl
more mappings
f381b47
@sgiehl
fix up old archives still using FIPS codes in API
08d3497
@sgiehl
finish fips to iso mapping
5ec9d9b
@sgiehl
adds some missing region names
58d2a5e
@sgiehl
fix tests
6552199
@sgiehl sgiehl mentioned this pull request Apr 5, 2018
Merged
@sgiehl
Copy link
Member Author

sgiehl commented Apr 5, 2018

will be replaced by #12699

@sgiehl sgiehl closed this Apr 5, 2018
@sgiehl sgiehl deleted the geoip2 branch May 4, 2018 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sgiehl sgiehl

Labels
Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review.
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.

Make geoip backend work with geoip2
2 participants
@sgiehl @mattab