New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove usage of synchronous ajax requests in the codebase #12546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: Will try to fix the UI tests soon. Seems they are failing as no synchronous request is blocking. Maybe need to add some more wait times |
sgiehl
force-pushed
the
donotusesyncajax
branch
6 times, most recently
from
February 13, 2018 21:00
472a773
to
139ea93
Compare
sgiehl
force-pushed
the
donotusesyncajax
branch
3 times, most recently
from
March 11, 2018 21:54
35560bb
to
189df4c
Compare
sgiehl
force-pushed
the
donotusesyncajax
branch
from
March 25, 2018 13:51
189df4c
to
7de3ec2
Compare
tsteur
requested changes
Mar 28, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test
sgiehl
force-pushed
the
donotusesyncajax
branch
2 times, most recently
from
April 1, 2018 16:38
fd91620
to
f83c2d2
Compare
InfinityVoid
pushed a commit
to InfinityVoid/matomo
that referenced
this pull request
Oct 11, 2018
* Do not use sync ajax requests * adds deprecation comments * convert some methods to be fully async * adds minimum waittime after page load in ui tests * improve wait times
mattab
changed the title
Remove usage of synchronous ajax requests
Remove usage of synchronous ajax requests in the codebase
Sep 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes all usages of synchronous ajax requests and adds a deprecation note for it.
With #11756 the possibility for synchronous ajax will be removed in Matomo 4 finaly.
refs #8246