Use more font icons instead of images #12532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
force-pushed
the
usemorefonticons
branch
2 times, most recently
from
df6dffb
to
f15b9a3
Compare
sgiehl
force-pushed
the
usemorefonticons
branch
3 times, most recently
from
5b15cbd
to
fcc1b16
Compare
|
LGTM |
|
Great choice of icons! 🎉 @sgiehl could you maybe resolve the conflicts and merge the PR directly? |
sgiehl
force-pushed
the
usemorefonticons
branch
from
fcc1b16
to
eadc459
Compare
sgiehl
force-pushed
the
usemorefonticons
branch
from
60c6187
to
e2515b4
Compare
InfinityVoid
pushed a commit
to InfinityVoid/matomo
that referenced
this pull request
Oct 11, 2018
* Use more font icons instead of images * update ui files * fix test * update UI files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added some more icons to the matomo font for:
They look a bit different to the images we used before, but it's hard to find good vector graphics that matches the old ones. See the updated UI files...
The new icons are used in Overlay plugin and in all table reports as row action icons.
based on #12520
fixes #12465