@Findus23 opened this Issue on February 2nd 2018 Member

Seems like I am bad at hitting buttons 😄
When one clicks right of the login button (e.g. on demo.matomo.org) on the desktop page the mobile sidebar appears once. (Tested in firefox and chromium)
gif
(Would be nice if one could upload videos to github, converting a 37KB video to a 4.7 MB gif is quite inefficient)

@sgiehl commented on February 2nd 2018 Member

I guess that area is meant for touch devices so the menu opens when swiping from the side. Are you using a device with touch screen?

@Findus23 commented on February 2nd 2018 Member

No,
It’s a normal notebook without a touchscreen.
I haven’t looked into what is causing it.

@tsteur commented on February 3rd 2018 Member

It is likely a builtin jquery/materializecss feature

@justju commented on July 4th 2018

Made a simple PR.

But I think there is still a problem remaining.
The used side-nav-component from Materialize adds a 10px wide <div class='drag-target'> to the <body>. One on the left for mobile-left-menu and on one the right for mobile-top-menu. This renders both 10px areas unclickable.

10px of the Logout-Button are unclickable and 10px of the left sidebar. (Red bar in the screenshots)
image

I am just not sure about what is the best way to fix it:

  1. Materialize seems to use z-index. But then you would have to add position: relative, absolute or fixed. And should that be done in coreHome.less?
  2. One could also add the media-query from hide-on-large-only to drag-target in the CSS (coreHome.less ?) like:
    <a class='mention' href='https://github.com/media'>@media</a> only screen and (min-width: 993px) {
    .drag-target{
    display: none !important;
    }
    }
  3. Add the hide-on-large-only via JS (corehome.js ?)
  4. Wait for the update of Materialize and hope it'll be fixed.
    ...
@tsteur commented on July 4th 2018 Member

Point 2 seems best to me personally.

@justju commented on July 6th 2018

I updated the PR in a Point 2 like manner.

Powered by GitHub Issue Mirror