Can you add some tests for this? And ideally if possible also contain the code in one module or class. It looks otherwise bit fragile/hacked.
I've also tried to use it and saw eg
Not sure if it is normal to see a dash before others in Acquisition => Websites report? (maybe isn't related to this PR)
Also my understanding was we would not only always show it in two columns but maybe have an option or two different "flattening" features whether you want it grouped or not? Personally in most cases I wouldn't like this view and prefer it in one column.
changed the implementation. There's now an additional option as soon as flattening is active.
Tested locally and noticed some oddities w/ the UI, for example the keywords report:
the first column is left aligned w/ a lot of space, and the second column is right aligned. Happens in other reports as well.
Otherwise, works well and code looks good to merge.
@diosmosis I've seen the UI glitch as well. Tried to fix it, but actually it seems to be a lot work to change the code so there can be more than one
@tsteur I already changed the code, so by default the columns are shown as one (like it is at the moment), but there is another table option to split the rows
Good start! Here is my feedback:
Aggregate rows are hidden -> Show them Dimensions are shown combined -> Show dimensions separately The report is flat -> Make it hierarchical (default) The report is not showing the totals row -> Show totals row
Could we change the order
The report is flat -> Make it hierarchical (default) Dimensions are shown combined -> Show dimensions separately Aggregate rows are hidden -> Show them The report is not showing the totals row -> Show totals row