@sgiehl opened this Pull Request on January 31st 2018 Member
@tsteur commented on January 2nd 2019 Member

Can you add some tests for this? And ideally if possible also contain the code in one module or class. It looks otherwise bit fragile/hacked.

I've also tried to use it and saw eg
image

Not sure if it is normal to see a dash before others in Acquisition => Websites report? (maybe isn't related to this PR)

Also my understanding was we would not only always show it in two columns but maybe have an option or two different "flattening" features whether you want it grouped or not? Personally in most cases I wouldn't like this view and prefer it in one column.

@diosmosis commented on January 22nd 2019 Member

@sgiehl will you be able to update this PR?

@sgiehl commented on January 28th 2019 Member

changed the implementation. There's now an additional option as soon as flattening is active.

@diosmosis commented on March 11th 2019 Member

Tested locally and noticed some oddities w/ the UI, for example the keywords report:

image

image

the first column is left aligned w/ a lot of space, and the second column is right aligned. Happens in other reports as well.

Otherwise, works well and code looks good to merge.

@tsteur commented on March 11th 2019 Member

Also my understanding was we would not only always show it in two columns but maybe have an option or two different "flattening" features whether you want it grouped or not? Personally in most cases I wouldn't like this view and prefer it in one column.

What is the plan here @sgiehl @mattab

@sgiehl commented on March 11th 2019 Member

@diosmosis I've seen the UI glitch as well. Tried to fix it, but actually it seems to be a lot work to change the code so there can be more than one label column.

@tsteur I already changed the code, so by default the columns are shown as one (like it is at the moment), but there is another table option to split the rows

@mattab commented on March 18th 2019 Member

Good start! Here is my feedback:

  • make Dimension columns left-aligned (currently the second one is right aligned).
  • Row evolution icon would ideally appear in each column and have a different behavior. When the 1st column row evolution is clicked, it opens row evolution for this clicked label (without the sub-table/second dimension). When the second dimension's column row evolution is clicked, then row evolution shows the evolution for this particular row (Same behavior as "This report is hierarchical" view)
  • The open segmented visitor log isn't currently visible in the view like it is in the "hierarchical" view, but expected to see it.
  • in some cases there is a lot of empty space and looks like this (as reported by @diosmosis). Maybe there's a way to make the first label column less wide in this case?

Screenshot from 2019-03-18 15-31-00

  • Sorting (alphabetical) by the second column doesn't work for me (example url), see examples:

2
1

  • Currently when the report is flattened, options are in this order:
    Aggregate rows are hidden ->     Show them
    Dimensions are shown combined ->     Show dimensions separately
    The report is flat ->     Make it hierarchical (default)
    The report is not showing the totals row ->     Show totals row

    Could we change the order

    The report is flat ->     Make it hierarchical (default)
    Dimensions are shown combined ->     Show dimensions separately
    Aggregate rows are hidden ->     Show them
    The report is not showing the totals row ->     Show totals row
  • Maybe rename "Dimensions are shown combined" to "Dimensions are combined"
  • When the report is hierarchical, below "Make it flat", add the new option "Dimensions are combined -> Show dimensions separately" so that the feature is more accessible and from both views, not just flattened.
Powered by GitHub Issue Mirror