New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show flattened columns as extra columns in UI #12524
Conversation
4ebedc4
to
5fce3c9
Compare
c9c0145
to
5fa0410
Compare
1af6629
to
7c4e352
Compare
0dc8f1e
to
cd90367
Compare
@@ -106,6 +106,18 @@ private function flattenRow | |||
(Row $row, $rowId, DataTable $dataTable, $level, $dimensionName, | |||
$labelPrefix = '', $parentLogo = false) | |||
{ | |||
$dimensions = $dataTable->getMetadata('dimensions'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any chance to do this maybe in the HtmlTable visualisation or so? Be nice to have this feature contained in one class or so and not spread across core, visualisations, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sgiehl can you answer this comment when you have time? (same w/ above one)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if there is a better/easier way to get all dimensions that were flattened. The only thing I can think of would be to get the report's metadata and then iterate through all sub reports to get all the dimensions. But not sure if that would work correctly with custom reports.
Nevertheless I think it might make sense to always have the dimensions
metadata for flattened reports, as each dimension also has it's own metadata property. So the content of dimensions
metadata makes it easy to identify the available dimension metadata properties.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sgiehl will you be able to update this PR? |
4a679b0
to
22ae40a
Compare
…ting of those columns possible
should be fixed with the last commit. The display order of additional dimensions was reverse.
It is enabled for all reports where the dimension for the subtable differs. Otherwise it doesn't actually make much sense to split it up. Same applies to all pages reports. |
@diosmosis can you please review this quickly and merge if it looks good to you? |
No description provided.