@tsteur opened this Pull Request on January 30th 2018 Member

Adds the following new date segments (and dimensions basically):

  • visitEndServerDate
  • visitEndServerDayOfMonth
  • visitEndServerDayOfWeek
  • visitEndServerDayOfYear
  • visitEndServerMonth
  • visitEndServerQuarter
  • visitEndServerSecond
  • visitEndServerWeekOfYear
  • visitEndServerYear

Tests will need to be fixed afterwards.

@tsteur commented on February 4th 2018 Member

The only failing test now should be in CustomDimensions plugin a system test that we could fix when merged or so?

@tsteur commented on February 11th 2018 Member

FYI: Seems like the tests for test_AutoSuggestAPITest_visitEndServerDayOfWeek__VisitsSummary might be randomly failing. Will need to have an eye on it.

This Pull Request was closed on February 19th 2018
Powered by GitHub Issue Mirror