Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename our composer packages #12519

Closed
9 tasks done
sgiehl opened this issue Jan 29, 2018 · 13 comments
Closed
9 tasks done

Rename our composer packages #12519

sgiehl opened this issue Jan 29, 2018 · 13 comments
Assignees
Milestone

Comments

@sgiehl
Copy link
Member

sgiehl commented Jan 29, 2018

Our composer packages are still listed under the vendor piwik on packagist. As there is no way to rename them, we need to create new packages and mark the old ones as abandoned

I've already started and will try to rename the other over the next days

Renaming the php packages does only make sense with Matomo 4, so we can rename all namespaces and classes without the possibility to break any plugins. Imho it doesn't make sense to name the package matomo/* but the classes would still need something like use Piwik\*

@sgiehl sgiehl added this to the 4.0.0 milestone Jan 29, 2018
@AndoniLarz
Copy link

Hi, I'm willing to use the piwik/piwik package in my project so I'm wondering : if you rename it to matomo/matomo, will I still be able to use piwik/piwik in my composer.json or should I wait until you rename it and use matomo/matomo ?

@sgiehl
Copy link
Member Author

sgiehl commented Feb 2, 2018

@AndoniLarz what exactly are you going to use? It will take a while until we will rename this package, as we will likely do that in Matomo 4. As most of the remaining rename tasks will be done than. See #12420

@AndoniLarz
Copy link

AndoniLarz commented Feb 4, 2018

Well I wanted to integrate this package into my Symfony project (using 3.2.13 but soon upgrading to 3.3 or 3.4), and I wanted to know if you were going to rename it promptly so I should wait a bit, or if you were going to let it named piwik for some time.
Of course if you have some advice about how I could integrate piwik/matomo in my Symfony project (so I don't have to use two servers), I'd be glad to hear !

@robocoder
Copy link
Contributor

Is it possible to create dummy packages? So piwik/piwik requires matomo/matomo?

@sgiehl
Copy link
Member Author

sgiehl commented Feb 12, 2018

I don't think this would make much sense for most of the packages... We are changing the php namespaces for some of the packages, so if we want to provide dummy packages here, we would need to wrap the new namespaces into the old ones to have it still working

creativecoder added a commit to creativecoder/matomo-heroku that referenced this issue Aug 2, 2018
Note that some piwik packages are marked abandoned, but still required by piwik/piwik
matomo-org/matomo#12519
@N3X15
Copy link

N3X15 commented Mar 26, 2019

Is there something I'm supposed to be doing to fix my existing git installs? Keep getting:

Package piwik/cache is abandoned, you should avoid using it. Use matomo/cache instead.
Package piwik/decompress is abandoned, you should avoid using it. Use matomo/decompress instead.
Package piwik/ini is abandoned, you should avoid using it. Use matomo/ini instead.

after git fetch --all --prune && git checkout $RELEASE_TAG && git submodule update --init --recursive && composer i --no-dev

This doesn't really affect anything, but I've noticed some of my installs have fewer warnings than others.

@sgiehl
Copy link
Member Author

sgiehl commented Mar 26, 2019

you can ignore that messages. We will use the new packages in Matomo 4.

@N3X15
Copy link

N3X15 commented Mar 26, 2019

Thanks.

@sgiehl
Copy link
Member Author

sgiehl commented Jul 7, 2020

Renaming the composer package of device detector can be done somewhen later. I'm planning to to do that with a new major release of Device Detector, but as I didn't have much time to work on that the past months, I will postpone that. But won't hurt in matter of Matomo, as it uses an own namespace, that won't change.

Regarding the rename of the piwik/piwik package. Not sure if we should do that with Matomo 4? actually shouldn't hurt to do it and have both package names maybe?

@tsteur
Copy link
Member

tsteur commented Jul 7, 2020

@sgiehl personally no preference. Can we have easily both names? If that's possible be good.

@sgiehl
Copy link
Member Author

sgiehl commented Jul 8, 2020

personally no preference. Can we have easily both names? If that's possible be good.

Actually like we have it for the components. Even though they are renamed to matomo/* the new releases are still available with the piwik/* name as they use the same repo.
See https://packagist.org/packages/matomo/cache and https://packagist.org/packages/piwik/cache

For piwik/piwik, we might not even need to mark the package as abandoned if we don't wont to "force" people to switch to the new name

@tsteur
Copy link
Member

tsteur commented Jul 8, 2020

👍

@sgiehl sgiehl modified the milestones: 4.0.0, 4.0.0 RC Jul 21, 2020
@sgiehl sgiehl removed this from the 4.0.0-RC milestone Oct 1, 2020
@sgiehl sgiehl added this to the 4.0.0-RC milestone Oct 30, 2020
@sgiehl
Copy link
Member Author

sgiehl commented Oct 30, 2020

Just release a new major version of device-detector including the rename to matomo/device-detector

@sgiehl sgiehl closed this as completed Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants