Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use renamed composer packages #12518

Merged
merged 4 commits into from Feb 15, 2018
Merged

Use renamed composer packages #12518

merged 4 commits into from Feb 15, 2018

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jan 29, 2018

Our composer packages are still listed under the vendor piwik on packagist. As there is no way to rename them, we need to create new packages and mark the old ones as abandoned.

As the two packages below only provide text/yml files, that should be in use by any plugin it should be fine to rename them already...

  • piwik/referrer-spam-blacklist -> matomo/referrer-spam-blacklist
  • piwik/searchengine-and-social-list -> matomo/searchengine-and-social-list

@sgiehl sgiehl added the Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. label Jan 29, 2018
@sgiehl
Copy link
Member Author

sgiehl commented Jan 29, 2018

ping @Findus23. Maybe you need to update the icon tests when this gets merged as the directory name in vendor will change...

@sgiehl sgiehl mentioned this pull request Jan 29, 2018
9 tasks
@sgiehl sgiehl added Needs Review PRs that need a code review and removed Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. labels Jan 29, 2018
@Findus23
Copy link
Member

I fixed the tests:
https://travis-ci.org/matomo-org/matomo-icons/jobs/334882629#L1406
I forgot to not commit the composer.lock as the test should use the latest version.

@sgiehl sgiehl added this to the 3.3.1 milestone Feb 2, 2018
@sgiehl sgiehl merged commit 8716e8d into 3.x-dev Feb 15, 2018
@sgiehl sgiehl deleted the composerrenames branch February 15, 2018 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants