Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Url containing unencoded " character and segment #12503

Open
gstrat88 opened this issue Jan 24, 2018 · 0 comments
Open

Url containing unencoded " character and segment #12503

gstrat88 opened this issue Jan 24, 2018 · 0 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.

Comments

@gstrat88
Copy link

My url contains hash part like this:
#_inbox!{"sc":"0"}
In matomo database its saved like this:
#_inbox!{"sc":"0"}
So if I create a segment searching for this {"sc":"0"} it fails.

I created a plugin that overrides the segment expression so that i am converting " value from segment to " and it works.

Because I am not sure if it's a bug as " should be encoded in the url I believe it would be great if there was a SegmentExpression.value event allowing for altering the value that SegmentExpression::getSqlMatchFromDefinition produces, for cases like that and not only.

@Findus23 Findus23 added Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. Bug For errors / faults / flaws / inconsistencies etc. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. labels May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

3 participants