Awesome looks great and will be so useful making install easier 👍 I just noticed one more thing.
$this->getSubmitValue() may return
null so it may end up in
trim(null) which could result in notices or it will at least return an empty string
"" whereas we saved
null before (see
php -r "var_dump(trim(null));"). I'm not sure whether this will cause any side effects or so. Therefore it would be good to execute the
trim() only when
getSubmitValue does not return a
I'm not at work till monday, but you can push that yourself. I think it would be easiest to save the value in an variable and than use shorthand if to return the variable or null.
Should be done :)
Awesome, does it need to be done for DB Name as well? Just to avoid maybe a possible notice or so? In theory might not be needed to have a check there because we check for
!empty() later but may be still good to have?
Are you sure it throws a notice? Did not found any information about that?
Only HHVM seems to trigger a notice in some versions: https://3v4l.org/71CT5
Not sure whether Matomo works on HHVM or not.