$dateis null. This happened while I was developing and it took me a very long time to figure out what was going on. An exception would have helped.
Visualization. I found that was the one spot that didn't call this function before using
SitesManager.shouldPerformEmptySiteCheckevent so plugins can disable the check for certain sites.
API.Request.interceptevent to in
API\Proxy. If a plugin sets
$returnedValue, the actual function call is skipped.
Request.shouldDisablePostProcessingso plugins can disable datatable post processing for certain requests (if, for example, the request's post processing is done somewhere else).
totalsshows up when
serialize=1&original=1. Don't think this will have a effect on DB size since only the rows are stored in the DB. Not sure what else serializes DataTable.
Note: I can cherry pick this into multiple PRs if needed & am also open to changing it.
Request.getRenamedModuleAndAction not sure. How come this is needed? Is there an API and Controller with the same name? In theory,
Request.getRenamedModuleAndAction should actually only be applied to controllers as API's are not an action but rather a method:
@tsteur Modified this PR based on our slack convo, had to add two more changes to get my use case to work. Let me know if there's still an issue.
Looks good @diosmosis
I would have possibly triggered another event for the
$returnedValue to simply not pass two parameters by reference and maybe some other plugin changes
finalParameters but by then maybe some plugin has already set a
$returnedValue based on the initial
finalParameters but could also leave it like this. Having a separate event for that purpose of generating a response may be a bit more clear.
@tsteur Updated this PR to have a new event
Just one more thing: Can you mention the new events in the
CHANGELOG.md? Happy to merge afterwards
@tsteur rebased + edited the changelog, test failure seems unrelated.