Opt-out iframe customiser: accept single and double quotes characters in fontFamily #12494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattab
added
the
not-in-changelog
mattab
changed the title
|
I think this could potentially be vulnerable to CSS injection attacks, someone could inject css to stop a rule, close the See https://www.owasp.org/index.php/Testing_for_CSS_Injection_(OTG-CLIENT-005) for more info on css injection. Only one I think really affects matomo users would be data exfiltration via font-face CSS. |
|
@mattab nevermind about my comment, missed part of the code |
|
Code looks good, there are some UI test failures, but no screenshots are uploaded to travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.