Fix tests #12488
Merged
Fix tests #12488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
the
c: Tests & QA
sgiehl
force-pushed
the
fixtests
branch
2 times, most recently
from
7f99f87
to
86ffbb7
Compare
|
Seems it has been a timing issue. Adding a wait time fixed the problem. Seems all tests are working now (besides some tests that randomly failed). Will merge soon, so we can rebase/update the other PRs to check if some tests are broken there |
mattab
added
the
not-in-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to merging various Pull requests without having a look at the tests, there are now a lot of UI tests failing (>300). Most of the changes seems to be legit, but it took me a few hours nevertheless to go through all changes and check if they are correct or failures.
Remaining failing tests are currently the ActionsDataTable UI tests. It seems like the sorting isn't triggered anymore in the tests. It seems first UI build where it was failing is after merging the ZEN mode changes, but that might not necessarily be the reason. Need to investigate that further