Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve styling of shortcut help #12486

Merged
merged 4 commits into from Jan 21, 2018
Merged

improve styling of shortcut help #12486

merged 4 commits into from Jan 21, 2018

Conversation

Findus23
Copy link
Member

screenshot_20180119_212521

Improved the styling a bit (inspired by the Github Popup)

grafik

@Findus23 Findus23 added the c: Design / UI For issues that impact Matomo's user interface or the design overall. label Jan 19, 2018
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting... Didn't even know there is something like a kbd element.

I've updated the expected UI file. Should be good to merge now, but let's wait for the tests to finish

@sgiehl sgiehl added this to the 3.3.1 milestone Jan 20, 2018
@sgiehl sgiehl merged commit d54d14f into 3.x-dev Jan 21, 2018
@sgiehl sgiehl deleted the help-styling branch January 21, 2018 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants