Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old name "piwik" is not completely changed to "matomo" #12484

Closed
vekunz opened this issue Jan 19, 2018 · 6 comments
Closed

Old name "piwik" is not completely changed to "matomo" #12484

vekunz opened this issue Jan 19, 2018 · 6 comments
Labels
duplicate For issues that already existed in our issue tracker and were reported previously.

Comments

@vekunz
Copy link
Contributor

vekunz commented Jan 19, 2018

Hi, i just changed the subdomain of my personal Matomo to the new name. But because I forgot to add the new subdomain to the trusted domains list, I got a warning message. And in this warning message you forgot to change "piwik" to "matomo" in some cases.
I added a (german) screenshot of the warning (by the way there are some missing translations, and the button at the bottom is "missing").

bildschirmfoto 2018-01-19 um 09 01 55

@Findus23
Copy link
Member

Hi,

The change is only missing in the German translation:

"InjectedHostNonSuperUserWarning": "%1$sHier klicken um Piwik sicher zu betreten%2$s und die Warnung zu entfernen. Zusätzlich können Sie den Matomo Administrator kontaktieren und ihn auf dieses Problem hinweisen (%3$sHier klicken um eine E-Mail zu senden%4$s).",

The English source file has been replaced:

"InjectedHostNonSuperUserWarning": "%1$sClick here to access Matomo safely%2$s and remove this warning. You may also want to contact your Matomo administrator and notify them about this issue (%3$sclick here to email%4$s).",

If you want to help translating join Matomo on Transifex:
https://www.transifex.com/matomo/matomo

There you can find all Translations including "Piwik" (for the CoreHome plugin):
https://www.transifex.com/matomo/matomo/translate/#de/matomo-plugin-corehome/44536445?qt=Piwik

@vekunz
Copy link
Contributor Author

vekunz commented Jan 19, 2018

Ok, but the third "piwik" (in the path) is in an english string.

@Findus23
Copy link
Member

This seems to be caused by this line:

$view->invalidHostMessageHowToFix = '<p><b>How do I fix this problem and how do I login again?</b><br/> The Matomo Super User can manually edit the file piwik/config/config.ini.php
and add the following lines: <pre>[General]' . "\n" . 'trusted_hosts[] = "' . $invalidHost . '"</pre>After making the change, you will be able to login again.</p>
<p>You may also <i>disable this security feature (not recommended)</i>. To do so edit config/config.ini.php and add:
<pre>[General]' . "\n" . 'enable_trusted_host_check=0</pre>';

@matomoto
Copy link

Matomo 3.3.0

piwik/xxx-piwik.txt
piwik/tmp/cache/tracker/piwikcache_ReportFactoryMap_2-8ead3d86ffa59e619836946cb55bea78-en.php
piwik/tmp/cache/tracker/piwikcache_marketplace.api.2.0.plugins.checkUpdates.281823630ca0623a029202254aa2953e.php
piwik/tmp/cache/tracker/piwikcache_marketplace.api.2.0.plugins.bda6c92c88de2431ef1fc1f97f83f9af.php
piwik/tmp/cache/tracker/piwikcache_allSiteUrlsPerSite.php
piwik/tmp/cache/tracker/piwikcache_2.php
piwik/tmp/cache/tracker/piwikcache_Translations-en-171a3f59fbe7aa1718656cf11a34397500040668.php
piwik/tmp/cache/tracker/piwikcache_Translations-en-2febaebb86f3321e46993b609a6ec65bea917ff1.php
piwik/tmp/cache/tracker/piwikcache_Translations-de-2febaebb86f3321e46993b609a6ec65bea917ff1.php
piwik/tmp/cache/tracker/piwikcache_marketplace.api.2.0.plugins.a15caad8bbd2bdbf27d8836a65ea16e9.php
piwik/tmp/cache/tracker/piwikcache_general.php
piwik/vendor/piwik
piwik/vendor/piwik/piwik-php-tracker
piwik/misc/others/uninstall-delete-piwik-directory.php
piwik/misc/proxy-hide-piwik-url
piwik/piwik.php
piwik/js/piwik.min.js
piwik/js/piwik.js
piwik/piwik.js
piwik/plugins/Zeitgeist/templates/_piwikTag.twig
piwik/plugins/Zeitgeist/javascripts/piwikHelper.js
piwik/plugins/CoreHome/angularjs/piwikApp.config.js
piwik/plugins/CoreHome/angularjs/piwikApp.js
piwik/plugins/CoreHome/angularjs/common/services/piwik-api.spec.js
piwik/plugins/CoreHome/angularjs/common/services/piwik-api.js
piwik/plugins/CoreHome/angularjs/common/services/piwik-url.js
piwik/plugins/CoreHome/angularjs/common/services/piwik.js
piwik/plugins/CoreHome/angularjs/common/services/piwik.spec.js
piwik/plugins/Morpheus/javascripts/piwikHelper.js
piwik/plugins/Morpheus/fonts/piwik.ttf
piwik/plugins/Morpheus/fonts/piwik.svg
piwik/plugins/Morpheus/fonts/piwik.woff

;)

@sgiehl
Copy link
Member

sgiehl commented Jan 20, 2018

@matomoto We are not able to fully rename all files within the next releases, as that would break compatibility with older versions. We will likely rename the last files and classes with release of version 4.0.

@sgiehl
Copy link
Member

sgiehl commented Feb 2, 2018

Closing in favor of #12420

@sgiehl sgiehl closed this as completed Feb 2, 2018
@sgiehl sgiehl added the duplicate For issues that already existed in our issue tracker and were reported previously. label Feb 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate For issues that already existed in our issue tracker and were reported previously.
Projects
None yet
Development

No branches or pull requests

4 participants