Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GeoIP re-attribution: debug output not showing changes #12477

Closed
lwille opened this issue Jan 18, 2018 · 1 comment
Closed

GeoIP re-attribution: debug output not showing changes #12477

lwille opened this issue Jan 18, 2018 · 1 comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.

Comments

@lwille
Copy link

lwille commented Jan 18, 2018 •
edited

Actual Output:

DEBUG [2018-01-18 13:48:03] Updating visit with idvisit = 2944645199 (IP = 95.236.0.0). Changes: [array]

Expected output:

DEBUG [2018-01-18 13:48:03] Updating visit with idvisit = 2944645199 (IP = 95.236.0.0). Changes: {"location_country":"it","location_region":"15","location_city":"Catania","location_latitude":37.5,"location_longitude":15.1}

Suggested fix: use json_encode to print a readable representation of the changeset.

https://github.com/matomo-org/matomo/blob/master/plugins/UserCountry/VisitorGeolocator.php#L192
lwille added a commit to lwille/matomo that referenced this issue Jan 18, 2018
@lwille
visitorGeolocator: output actual changes in debug mode
fa956d4 
closes matomo-org#12477
@lwille lwille mentioned this issue Jan 18, 2018
Merged
mattab pushed a commit that referenced this issue Jan 18, 2018
@lwille @mattab
visitorGeolocator: output actual changes in debug mode (#12478)
19a7654 
closes #12477
@mattab
Copy link
Member

mattab commented Jan 18, 2018

Fixed in #12478

@mattab mattab closed this as completed Jan 18, 2018
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jan 18, 2018
mattab pushed a commit that referenced this issue Apr 23, 2018
@kachenjr @mattab
This addresses the various dead lock issues when using transactions a…
20e4daf 
…nd multiple recorders. (#12733)

* visitorGeolocator: output actual changes in debug mode (#12478)

closes #12477

* Revert "visitorGeolocator: output actual changes in debug mode (#12478)" (#12480)

This reverts commit 19a7654.

* Fix SystemIntegration test (#12726)

Found `piwik`

* This addresses the various dead lock issues when using transactions and bulk load.  Issue #6398

* Fix archive test to work with multi recorder fix.

* Minor changes and renames
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this issue Oct 11, 2018
@kachenjr @InfinityVoid
This addresses the various dead lock issues when using transactions a…
91059f1 
…nd multiple recorders. (matomo-org#12733)

* visitorGeolocator: output actual changes in debug mode (matomo-org#12478)

closes matomo-org#12477

* Revert "visitorGeolocator: output actual changes in debug mode (matomo-org#12478)" (matomo-org#12480)

This reverts commit 19a7654.

* Fix SystemIntegration test (matomo-org#12726)

Found `piwik`

* This addresses the various dead lock issues when using transactions and bulk load.  Issue matomo-org#6398

* Fix archive test to work with multi recorder fix.

* Minor changes and renames
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lwille @mattab