@tsteur opened this Pull Request on January 17th 2018 Member
@diosmosis commented on June 14th 2018 Member

@tsteur is this still a WIP or is it ready to review now?

@tsteur commented on June 14th 2018 Member

It is WIP

@tsteur commented on April 17th 2019 Member

@mattab can you have a look at it? I can add some challenges to Custom Dimensions, Custom Alerts, and other premium features once this has been merged.

@tsteur commented on April 29th 2019 Member

ping @mattab

@mattab commented on June 10th 2019 Member

@diosmosis can you please review this quickly and merge if it looks good to you? Be good to get it out in 3.10.0 and test it and get early feedback :+1:

@diosmosis commented on June 11th 2019 Member

Tour_MatomoTalent is missing a translation.

@diosmosis commented on June 11th 2019 Member

Noticed Tour is not enabled in an update. This is expected, correct?

@diosmosis commented on June 11th 2019 Member

Small issue, doesn't seem simple to fix: when clicking on a tour task, a new tab is opened. When the task is finished, we don't go back to the dashboard nor does the widget in the dashboard update w/ a check mark. This might be confusing to new users.

@diosmosis commented on June 11th 2019 Member

Found some issues while testing, code looks ok but I didn't have time to look thoroughly.

@tsteur commented on June 11th 2019 Member

Small issue, doesn't seem simple to fix: when clicking on a tour task, a new tab is opened. When the task is finished, we don't go back to the dashboard nor does the widget in the dashboard update w/ a check mark. This might be confusing to new users.

I'll listen to window focus and update the widget in that case.

Fixed all the other issues you mention including translation, update, ... Except for the link to #customLogo .

@diosmosis commented on June 11th 2019 Member

I'll listen to window focus and update the widget in that case.

👍 nice idea, super simple

@diosmosis commented on June 12th 2019 Member

one more product related comment: I think there's an issue w/ referring to the user as beginner/expert, since that implies we're teaching them about analytics, not just where certain features in the app are. Eg, adding a goal doesn't necessarily mean the user knows how best to use one, and a user will know that when we call them an expert.

Either the tour is something like "here are some of matomo's most useful features/here is how to get the most out of matomo" or "here is how you use this tool to better your business (and be an expert in analytics)" which is a much harder thing to deliver.

@tsteur commented on June 12th 2019 Member

It's certainly meant more for "Here are some of matomo's most useful features/here is how to get the most out of matomo". That's why I was prefixing expert etc with "Matomo Expert" and "Matomo Professional" and "Matomo Beginner"... and not just "Professional" or "Analytics Professional". Does this maybe help?

@diosmosis commented on June 12th 2019 Member

"Expert" just suggests the user will be an expert in using matomo after doing those tasks, and I doubt anyone new to the tool will actually feel that way. Which may not be the best experience.

@mattab commented on June 18th 2019 Member

Great feature and looking forward to seeing it help people get started complete the most important steps! :+1:

Agreed that the naming is currently not ideal, and we'll likely change the names of the levels soon. But will merge already so we can proceed with the release, and will create a new issue once I can think of better names (any suggestion welcome!).
(Maybe a star system 1-5 stars that look good/positive at whever level people are at.)

@katebutler commented on June 18th 2019 Member

Have generated expected files for the system tests.

@mattab commented on June 18th 2019 Member

@tsteur could you investigate this build failure:

1) Piwik\Plugins\Tour\tests\System\APITest::testApi with data set <a href='/0'>#0</a> (array('Tour.getLevel', 'Tour.getChallenges'), array(1))
Piwik\Plugins\Tour\tests\System\APITest: Differences with expected in '/home/travis/build/matomo-org/matomo/plugins/Tour/tests/System/processed/test___Tour.getChallenges.xml'
Failed asserting that two DOM documents are equal.
--- Expected
+++ Actual
@@ @@
     <isSkipped>0</isSkipped>
-    <url>index.php?module=CoreAdminHome&amp;action=generalSettings#useCustomLogo</url>
+    <url>index.php?module=CoreAdminHome&amp;action=generalSettings#/#useCustomLogo</url>
   </row>
   <row>

I will merge anyway in the meantime

This Pull Request was closed on June 18th 2019
Powered by GitHub Issue Mirror