Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modals popover can now be closed with keyboard #12462

Merged
merged 1 commit into from Jan 18, 2018

Conversation

Jouveer
Copy link
Contributor

@Jouveer Jouveer commented Jan 17, 2018

Possible solution to #12439
Changed focus to the anchor on "no" button

@Findus23
Copy link
Member

@Jouveer many thanks for the fix, it works for me.
I'm not sure if it is better to focus on the "yes" button per default. (On one hand it's more common, but on the other hand also more prone to accidentally deleting something)

Have you tried if it is possible to focus while the animation is still running? Because now when you press enter while the dialog is still animation again another one pops up.

@mattab mattab added this to the 3.3.1 milestone Jan 18, 2018
@mattab
Copy link
Member

mattab commented Jan 18, 2018

I'm not sure if it is better to focus on the "yes" button per default. (On one hand it's more common, but on the other hand also more prone to accidentally deleting something)

let's leave it by default for now, as all modals focus on NO by default. It's safest option for users 👍

Have you tried if it is possible to focus while the animation is still running? Because now when you press enter while the dialog is still animation again another one pops up.

That's indeed an issue. @Jouveer Maybe you could fix this one in a separate PR?

@mattab mattab changed the title Modal Button Fix Modals popover can now be closed with keyboard Jan 18, 2018
@mattab mattab merged commit ed78cc9 into matomo-org:3.x-dev Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants