Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rough way of adding the page up and page down shortcuts to help list #12461

Merged
merged 2 commits into from Jan 18, 2018

Conversation

ryyee99
Copy link
Contributor

@ryyee99 ryyee99 commented Jan 17, 2018

fix #12456

@sgiehl
Copy link
Member

sgiehl commented Jan 18, 2018

I'm not sure if #12456 was meant to only add that on the info screen. Imho we should only list shortcuts we have implemented on our own! Listing common browser shortcuts does not make much sense

@mattab mattab added this to the 3.3.1 milestone Jan 18, 2018
@tsteur
Copy link
Member

tsteur commented Jan 18, 2018

FYI: We added this shortcut as it is a very useful one and if the browser didn't implement it already, you would expect Matomo to have a shortcut for it. That's why we thought it will be good to show the shortcut. We won't list all the browser shortcuts but a very few ones like this one may be listed in this dialog.

@tsteur
Copy link
Member

tsteur commented Jan 18, 2018

Awesome well done 👍 💯

@tsteur tsteur merged commit 69352ce into matomo-org:3.x-dev Jan 18, 2018
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new keyboard shortcuts for Top/Bottom of page
4 participants