Shows icon to disable/enable Zen Mode #12459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattab
requested changes
Jan 17, 2018
There was a problem hiding this comment.
Thank you for your pull request @ryyee99 !
Code review & Feedback
- Hide the icon in the mobile view (and possibly tablet view)
- Add a tooltip on the icon when hovered
Enter Zen mode (hide the menus), andExit Zen mode (show the menus) - Show the icon in the admin screen screen as well (currently the icon is not visible in admin screen)
Findus23
reviewed
Jan 18, 2018
Findus23
added
c: Design / UI
|
I'd still recommend to add a padding to the button. At the moment it's really hard to hit the button as it's only 10x16 pixel large. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #9263 (comment)