Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Feeds URL to HTTPS #12449

Merged
merged 4 commits into from Jan 18, 2018
Merged

Changed Feeds URL to HTTPS #12449

merged 4 commits into from Jan 18, 2018

Conversation

@Findus23
Copy link
Member

Hi,
This is related to #11016.
While I definitely agree that we should be using https everywhere (also for fetching and checking updates and the marketplace), this needs a lot of testing as many people have a broken php curl setup. (Very outdated ca list or #11451)

@@ -23,7 +23,7 @@ public static function configure(WidgetConfig $config)
public function render()
{
try {
$rss = new RssRenderer('http://feeds.feedburner.com/Piwik');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this class RssPiwik we need to apply the same changes as in RssChangelog (https and fallback to http)

@mattab mattab added this to the 3.3.1 milestone Jan 18, 2018
@mattab mattab merged commit df04267 into matomo-org:3.x-dev Jan 18, 2018
@mattab
Copy link
Member

mattab commented Jan 18, 2018

Great @Jouveer this works 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants