Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention Matomo is formerly known as Piwik in help page #12440

Merged
merged 2 commits into from Jan 15, 2018

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Jan 12, 2018

No description provided.

@tsteur tsteur added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jan 12, 2018
@tsteur tsteur added this to the 3.3.0 milestone Jan 12, 2018
@tsteur tsteur added the Needs Review PRs that need a code review label Jan 12, 2018
lang/en.json Outdated
@@ -320,7 +320,7 @@
"Password": "Password",
"Period": "Period",
"Piechart": "Piechart",
"PiwikIsACollaborativeProjectYouCanContributeAndDonateNextRelease": "%1$sMatomo%2$s is a collaborative project brought to you by the %7$sMatomo team%8$s members as well as many other contributors around the globe. <br/> If you're a fan of Matomo, you can help: find out %3$sHow to participate in Matomo%4$s, or %5$sdonate now%6$s to help fund the next great Matomo release!",
"PiwikIsACollaborativeProjectYouCanContributeAndDonateNextRelease": "%1$sMatomo%2$s, formerly known as Piwik, is a collaborative project brought to you by the %7$sMatomo team%8$s members as well as many other contributors around the globe. <br/> If you're a fan of Matomo, you can help: find out %3$sHow to participate in Matomo%4$s, or %5$sdonate now%6$s to help fund the next great Matomo release!",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we maybe also change the key of the translation and replace Piwik with Matomo there? We may need to change that everywhere over time, but why not starting here if we already change the content...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 done

@sgiehl sgiehl modified the milestones: 3.3.0, 3.3.1 Jan 15, 2018
@sgiehl sgiehl merged commit 467183d into 3.x-dev Jan 15, 2018
@sgiehl sgiehl deleted the helppageformerlypiwik branch January 15, 2018 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants