Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modal can't be closed with keyboard #12439

Closed
Findus23 opened this issue Jan 12, 2018 · 1 comment
Closed

modal can't be closed with keyboard #12439

Findus23 opened this issue Jan 12, 2018 · 1 comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone

Comments

@Findus23
Copy link
Member

Another odd issue:

unbenannt

How to reproduce:

  1. delete email report
  2. try to accept the modal by pressing "enter" or "space"
  3. another modal will popup
  4. repeat until you get bored

really minor bonus bug: even after closing the modal they don't get removed from the DOM

@tsteur tsteur added the Bug For errors / faults / flaws / inconsistencies etc. label Jan 15, 2018
@tsteur tsteur added this to the 3.4.0 milestone Jan 17, 2018
@mattab
Copy link
Member

mattab commented Jan 18, 2018

fixed in #12462

@mattab mattab closed this as completed Jan 18, 2018
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jan 18, 2018
@mattab mattab modified the milestones: 3.4.0, 3.3.1 Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

No branches or pull requests

3 participants