Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish renaming Piwik to Matomo everywhere #12420

Open
17 of 21 tasks
mattab opened this issue Jan 10, 2018 · 9 comments
Open
17 of 21 tasks

Finish renaming Piwik to Matomo everywhere #12420

mattab opened this issue Jan 10, 2018 · 9 comments
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. Technical debt Issues the will help to reduce technical debt
Milestone

Comments

@mattab
Copy link
Member

mattab commented Jan 10, 2018

In January 2018 we announced that Piwik is now Matomo 馃帀

As part of the renaming efforts we're updating all our websites, tools, core app, plugins, ie. everything!

Renaming checklist left to do:

In the case of Matomo core platform we want to keep things backward compatible for users including HTTP APIs users or users of the JavaScript SDKs.

Assigning to Matomo 4.0.0 but hopefully we can tackle a few of the list, and make progress on the others, during Matomo 3.x 馃殌

@mattab mattab added Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. labels Jan 10, 2018
@mattab mattab added this to the 4.0.0 milestone Jan 10, 2018
@linusg
Copy link

linusg commented Jul 15, 2018

Hey there,
not sure if there's a separate repo for the website (matomo.org, didn't found one), but I think it will fit in here.

On the main page, there's this animation:

image

On the truck it say's Piwik, so that should be changed at one point in the future. :-)

Cheers!

@tsteur
Copy link
Member

tsteur commented Apr 13, 2020

As part of this issue it be important to look at which ones are easy and quick to do. The rest we'll do as part of Matomo 5.

@tsteur
Copy link
Member

tsteur commented Jun 5, 2020

for tracker created matomo-org/tracker-proxy#61

@tsteur
Copy link
Member

tsteur commented Jun 12, 2020

I reckon we can move the rest to Matomo 5? The only question would be wether we want to release another Matomo 2 and Matomo 3 update with the legacy auto loader: https://github.com/matomo-org/matomo/blob/4.x-dev/LegacyAutoloader.php#L17

This way should we ever change the namespace then it would cause less upgrade issues.

@sgiehl @mattab I reckon it could make sense to add the autoloader and release new version also for Matomo 2.* users

@sgiehl
Copy link
Member

sgiehl commented Jun 14, 2020

@tsteur Yes. Guess it makes sense to release new versions for 2.x and 3.x with the autoloader, so we have smoother updates later...

@tsteur
Copy link
Member

tsteur commented Jun 15, 2020

@sgiehl created this for 3.x-dev: https://github.com/matomo-org/matomo/compare/3.x-dev...legacyautoloader?expand=1 would create the same for 2.x-dev... do you reckon this would help?

Generally thinking the autloader needs to work both ways Piwik -> Matomo and Matomo -> Piwik

  • Core updater runs with 3.x, all files from Matomo are being updated
  • Now it tries to request \Piwik\Http class in https://github.com/matomo-org/matomo/blob/3.13.6/plugins/CoreUpdater/Updater.php#L131
  • Because the file core/Http was replaced this file will contain \Matomo\Http... and no longer \Piwik\Http...
  • The error would not be solved by this legacy autoloader unless we add alias as needed both ways (which I now did in the updated code base)

On another note noticed there is also interface_exists. Hoping we won't run into any issues around interfaces but luckily we don't use them much :)

@sgiehl
Copy link
Member

sgiehl commented Jun 15, 2020

Aren't we running most of the update process on the new code base? 馃
But guess it makes sense to have the autoloader in both ways, to be sure there can't be any renamed class missing...

@tsteur
Copy link
Member

tsteur commented Jun 18, 2020

FYI we basically need to release a Matomo 2 release and then we can move this issue into Matomo 5 milestone.

@rklrkl
Copy link

rklrkl commented Jan 6, 2024

I just updated to Matomo 5.0.1 and post-update "Matomo Changelog" panel says "See the latest changes in Piwik.". Doing a quick scan of the Web tree, I found the HTML code in /tmp/cache/tracker/matomocache_RSS_d88870a6de03bc454328f6b17452cb70.php so I'm guessing this is supplied by matomo.org and then cached locally. I think this might be the first time I've seen an incorrect visible textual reference to Piwik after logging in to our local Matomo instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. Technical debt Issues the will help to reduce technical debt
Projects
None yet
Development

No branches or pull requests

6 participants