Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove "hoverable" class from divs #12408

Closed
wants to merge 1 commit into from
Closed

Conversation

Findus23
Copy link
Member

@Findus23 Findus23 commented Jan 7, 2018

One thing that is bugging me a bit since Piwik 3 is that the cards in the visitor log are all animated on hover.
In my opinion such a strong animation should be limited to small objects and it always indicates that one can interact with it as it's a link or button.
I am not sure why the visitor log cards "move" as no other similar cards (sidebar/other reports) do so apart from the "manage websites" list for which I'd propose the same change.

@Findus23 Findus23 added the c: Design / UI For issues that impact Matomo's user interface or the design overall. label Jan 7, 2018
@mattab mattab added this to the 3.4.0 milestone Jan 10, 2018
@mattab mattab added the Needs Review PRs that need a code review label Jan 10, 2018
@tsteur
Copy link
Member

tsteur commented Jan 11, 2018

That was me who added it. I found it quite useful especially when there are many boxes but I have no strong opinion here and it can be removed for sure. I can see that it possibly could be annoying.

@Findus23
Copy link
Member Author

I also don't have such a strong opinion on it, so I'd wait for more other opinions.

@mattab
Copy link
Member

mattab commented Jul 24, 2018

I also think it's quite useful and a bit of interaction/animation in the product. will close it for now but thanks for the suggestion.

@mattab mattab closed this Jul 24, 2018
@sgiehl sgiehl deleted the no-hover-on-divs branch April 28, 2020 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants