Show error message if visitor in visitor profile could not be found instead of fatal error #12396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstead of fatal error Eg happens when visitorId URL parameter is missing.
tsteur
commented
Jan 3, 2018
plugins/Live/Controller.php
Outdated
| @@ -114,10 +120,17 @@ public function getVisitorProfilePopup() | |||
| { | |||
| $idSite = Common::getRequestVar('idSite', null, 'int'); | |||
|
|
|||
| Piwik::checkUserHasViewAccess($idSite); | |||
There was a problem hiding this comment.
Not sure why above we use Common::getRequestVar... instead of $this->idSite
There was a problem hiding this comment.
Guess it shouldn't make a difference to use $this->idSite instead
sgiehl
reviewed
Jan 3, 2018
plugins/Live/Controller.php
Outdated
| @@ -114,10 +120,17 @@ public function getVisitorProfilePopup() | |||
| { | |||
| $idSite = Common::getRequestVar('idSite', null, 'int'); | |||
|
|
|||
| Piwik::checkUserHasViewAccess($idSite); | |||
There was a problem hiding this comment.
Guess it shouldn't make a difference to use $this->idSite instead
|
It is not really for invalid profiles, but more for when the parameter is missing (although would also apply later to possibly deleted profiles once supported by Piwik). Test be useful, need to see when I get to it. |
mattab
modified the milestones:
3.5.0,
Priority Backlog (Help wanted),
Backlog (Help wanted)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added some permissions check. They are not 100% needed as the permissions are checked in the API calls anyway but makes sure they don't get random data from API response and shows always login screen instead of potentially a fatal error.