Prevent possible error when goal deleted. #12395
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should prevent an error like this:
```
Error: {"message":"Key \"\" for array with keys \"4\" does not exist.","file":"plugins\/Live\/templates\/_profileSummary.twig","line":24}
```
The visitor log / profile fetches currently all goal conversions and does check whether a goal still exists so not sure why it is needed (in https://github.com/piwik/piwik/blob/3.3.0-b1/plugins/Goals/VisitorDetails.php#L67 ). Where this happened the goal actually exists but the other first 3 goals are deleted.
Here is some output from visitor data and idGoal 4 is definitely set in `goals`
```
["totalConversionsByGoal"]=>
array(2) {
[1]=>
int(0)
["idgoal=4"]=>
int(1)
}
```
|
Actually, the bug was caused by another plugin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should prevent an error like this:
The visitor log / profile fetches currently all goal conversions and does check whether a goal still exists so not sure why it is needed (in https://github.com/piwik/piwik/blob/3.3.0-b1/plugins/Goals/VisitorDetails.php#L67 ). Where this happened the goal actually exists but the other first 3 goals are deleted.
Here is some output from visitor data and idGoal 4 is definitely set in
goalsIt seems to cause an error when there is also an ecommerce action like here where I printed also
{{ goals|json_encode }}{{ visitorData.totalConversionsByGoal|json_encode }}:Actually: This does not fix the problem because it would never show any entry as
idgoal=4cannot be set inGoalsso there must be a different fix.