Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move public static functions out of Live controller #12394

Closed
tsteur opened this issue Jan 2, 2018 · 0 comments · Fixed by #12406
Closed

Move public static functions out of Live controller #12394

tsteur opened this issue Jan 2, 2018 · 0 comments · Fixed by #12406
Assignees
@sgiehl
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
Backlog (Help wan...

Comments

@tsteur
Copy link
Member

tsteur commented Jan 2, 2018

All methods that are not supposed to be called from the outside should be moved to another class. Especially all the protected/public static function methods.
@tsteur tsteur added the Bug For errors / faults / flaws / inconsistencies etc. label Jan 2, 2018
@tsteur tsteur added this to the 3.3.0 milestone Jan 2, 2018
@sgiehl sgiehl self-assigned this Jan 6, 2018
@sgiehl sgiehl mentioned this issue Jan 6, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
Backlog (Help wanted)
Development

Successfully merging a pull request may close this issue.

Move methods away from Live controller matomo-org/matomo
3 participants
@tsteur @mattab @sgiehl