@sgiehl opened this Pull Request on December 20th 2017 Member

Shown visits in visitor profile is currently limited by live_visitor_profile_max_visits_to_aggregate (default 100). As some users might exceed this limit it would be helpful to show at least a message that the summary only represents the last X visits.

based on #12375

refs #12373

@diosmosis commented on March 20th 2018 Member

System test is failing (makeVisitorTableFromArray() call added in previous PR is missing the new $rowCount parameter). Otherwise looks good.

@diosmosis commented on March 23rd 2018 Member

Not sure why, but FOUND_ROWS() isn't working on travis or for me locally. Still investigating...

@diosmosis commented on March 23rd 2018 Member

found the issue, it's caused by the limit in the inner query: https://github.com/matomo-org/matomo/blob/3.x-dev/plugins/Live/Model.php#L264-L268

FOUND_ROWS() will always be limited by that, I guess. @sgiehl is this something you noticed? or was it working for you?

@sgiehl commented on March 25th 2018 Member

Guess that worked in my tests, as the datasets were smaller than the $limit*10. But now only $limit is beeing used as iIrc a segment has been used before to load that data instead of directly using the $visitorId parameter. Need to have a closer look when I have some time if there is an easy solution for this...

@mattab commented on April 23rd 2018 Member

LGTM :+1:

This Pull Request was closed on April 23rd 2018
Powered by GitHub Issue Mirror