System test is failing (
makeVisitorTableFromArray() call added in previous PR is missing the new
$rowCount parameter). Otherwise looks good.
Not sure why, but
FOUND_ROWS() isn't working on travis or for me locally. Still investigating...
found the issue, it's caused by the limit in the inner query: https://github.com/matomo-org/matomo/blob/3.x-dev/plugins/Live/Model.php#L264-L268
FOUND_ROWS() will always be limited by that, I guess. @sgiehl is this something you noticed? or was it working for you?
Guess that worked in my tests, as the datasets were smaller than the
$limit*10. But now only
$limit is beeing used as iIrc a segment has been used before to load that data instead of directly using the
$visitorId parameter. Need to have a closer look when I have some time if there is an easy solution for this...