Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in the console command diagnostics:run, display a success message when all checks are green #12342

Merged
merged 1 commit into from Dec 14, 2017

Conversation

mattab
Copy link
Member

@mattab mattab commented Dec 8, 2017

Currently the command returns nothing when it's successful, which is not quite clear

With this PR:

$ ./console diagnostics:run
Huzzah! There are no problems with your Piwik setup. Give yourself a pat on the back.

@mattab mattab added c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Needs Review PRs that need a code review labels Dec 8, 2017
@mattab mattab added this to the 3.2.2 milestone Dec 8, 2017
@mattab mattab merged commit 8374eae into 3.x-dev Dec 14, 2017
@mattab mattab deleted the diagnostics branch December 14, 2017 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant