Respect maintenance mode when archiving #12339
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When maintenance mode is enabled the archiver should not start and also not start working on a next website.
On top we could throw an exception in
archiveReportsFor()
but AFAIK the request will fail anyway since the API will basically return an error. And inarchiveReportsFor()
should not be like aif (maintenanceEnabled) return
because it could result in random bugs as we might set some flags like the site was considered archived. If we want to avoid sending requests eg inarchiveReportsFor()
we should throw an exception instead likeif (maintenanceEnabled) throw new Exception('Maintenance mode is enabled')
so the core archiver will stop.Feel free to tweak messages.